Reject elements which have duplicated dependencies

Daniel Silverstonerequested to merge
danielsilverstone-ct/load-reject-duplicates into master

Description

Prevent the loading of elements which have duplicated dependencies.

Changes proposed in this merge request:

  • Introduce a LoadErrorReason.DUPLICATE_DEPENDENCY
  • Raise a LoadError with that, when elements have duplicate dependencies
  • Test that for all combinations of dependency type

This merge request, when approved, will close: #1077 (closed)

Since this adds work to the load pathways, here's a --config normal --show-only benchmark of my branch

commit action python_version max_memory time
danielsilverstone-ct/load-reject-duplicates - c6bbcc43 show py35 196 6.47
master - 5a42a27b show py35 196 6.52

I'd say that since it's unlikely my branch causes less work to be done, it's more likely that the work it does add is simply lost in the noise.

Merge request reports