Make Node attributes c-only accessible and optimize node creation (!1453) · Merge requests · BuildStream / buildstream · GitLab

This project is archived. Its data is read-only.

Sign in or sign up before continuing. Don't have an account yet? Register now to get started.

Description

This optimizes node access and creation. Since nodes is a central place of the codebase, this brings a measurable speed improvement.

Also, making node attributes c-only accessible, ensures users are forced to go through the real plugin API.

Changes proposed in this merge request:

Make file-info parts of the Node into the Node private
Move the value of the node into each subnode
Prevent direct instantiation of nodes and optimize creation.
- This is related to https://cython.readthedocs.io/en/latest/src/userguide/extension_types.html#fast-instantiation