Skip to content
Snippets Groups Projects

setup.py: Be more restrictive with BST_CYTHON_TRACE values

Merged Benjamin Schubert requested to merge bschubert/fix-cython-trace into master

Description

"0" evaluates to True in python, which incorrectly switched on the BST_CYTHON_TRACE. Forcing an int for this environment variable allows us to ensure we are correct.

Merge request reports

Pipeline #64395204 passed with warnings

Pipeline passed with warnings for 24637421 on bschubert/fix-cython-trace

Test coverage 86.96% from 1 job
Approved by

Merged by bst-marge-botbst-marge-bot 5 years ago (Jun 3, 2019 10:38am UTC)

Merge details

  • Changes merged into master with 6b1f0476.
  • Deleted the source branch.

Pipeline #64508851 failed

Pipeline failed for 6b1f0476 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading