Skip to content

_sandboxremote.py: Create marked directories before running

Jim MacArthurrequested to merge
jmac/make_marked_directories into master

Description

A fix for #851 (closed). The two local sandboxes (BWrap and chroot) both create all marked directories (that is, all directories which have been passed to Sandbox.mark_directory) before running as part of MountMap. Since the remote sandbox didn't do any mounts, it ignored marked directories. install-root is one of these, and other code expects it to be there. Existing BuildStream projects may also rely on this behaviour.

Proposed changes

  • Create all marked directories before running a command in a remote sandbox.

This merge request, when approved, will close: #851 (closed)

Merge request reports