Skip to content

Misc fixes to the tests and newer linter errors

Tristan Van Berkom requested to merge tristan/test-fixes into master

This branch:

  • Fixes #636 (closed) by depending on new pytest-datafiles release
  • Removes the pinning of older version of pylint
  • Fixes the most recent linter errors, which appear with the latest pylint

This should fix the tests to pass on developer laptops, however, it will only work when the developer laptop system dependencies are up to date with what we expect.

It appears, contrary to what one would expect, that system installed libraries shadow the versions required explicitly by BuildStream. For example, I ran into this issue and found this comment which fixed it for me, while trying to test out newer pylint: https://github.com/pytest-dev/pytest/issues/3753#issuecomment-418134963

A more complete fix for consistently passing tests on developer laptops will probably be to change our setup to use tox for tests.

Merge request reports