Create Artifact abstraction class

Background

For Artifact as a Proto an abstract Artifact class, which will implement artifact specific functions which currently reside in Element.

Task description

• Create list of existing functions that should be abstracted out of Element via Artifact

Current list of potential artifact related funcs to abstract:

• __compute_splits (imports files dir of artifact)

• stage_artifact (imports files dir of artifact)

• _stage_sources_at (checks if a requested buildtree is cached empty)

• _cache_artifact

• _get_build_log

• _cached_buildtree

• __extract

• __get_artifact_metadata_keys

• __get_artifact_metadata_dependencies

• __get_artifact_metadata_workspaced

• __get_artifact_metadata_workspaced_dependencies

• __load_public_data

• __load_build_result

• Abstract out, no new tests to be added

Acceptance Criteria

Current bst functionality is preserved

---

changed the description

mentioned in issue #909 (closed)

changed the description

marked this issue as related to #909 (closed)

I expect to prune the list once implementation starts. Creating the class and then moving methods over piece by piece, ensuring tests work between each commit. Core abstractions should be in place before 'nice to have' refactors are considered.

*Note abstraction not used in the strict sense of abstract base classes

I plan to move over aspects of __load_build_result & _cached_buildtree as initial abstractions

marked the checklist item __extract as completed

marked the checklist item __load_build_result as completed

marked the checklist item __load_public_data as completed

marked the checklist item _cache_artifact as completed

marked the checklist item _cached_buildtree as completed

changed the description

marked the checklist item __get_artifact_metadata_keys as completed

marked the checklist item __get_artifact_metadata_dependencies as completed

marked the checklist item __get_artifact_metadata_workspaced as completed

marked the checklist item __get_artifact_metadata_workspaced_dependencies as completed

marked the checklist item _get_build_log as completed

changed the description

mentioned in merge request !1175 (merged)

I've pushed a WIP for this with my current transitions

changed the description

marked the checklist item _stage_sources_at (checks if a requested buildtree is cached empty) as completed

changed the description

marked the checklist item stage_artifact (imports files dir of artifact) as completed

marked the checklist item __compute_splits (imports files dir of artifact) as completed

marked this issue as related to #945 (closed)

closed via merge request !1175 (merged)

mentioned in commit 2c3dfa4e