Failed builds not pushing artifacts on quit
Summary
If, when a build fails, the user quits instead of continuing, the artifact will not be pushed
Steps to reproduce
Build a project that fails,
When given the options of (t)terminate, (q)quit, (c)continue
select q
Check for the artifact in the cache
The artifact should be missing
What is the expected correct behavior?
The failed build artifact should be cached even when the quit option is selected
Possible fixes
One option is to have the artifact be cached at the point of the build failing, so at the point of choosing whether or not to continue, it is already cached
Other relevant information
- BuildStream version affected: /milestone %BuildStream_v1.4