Commits on Source 2

  • Chandan Singh's avatar
    testutils/site.py: Support parsing more exotic git versions · dd791373
    Chandan Singh authored and Chandan Singh's avatar Chandan Singh committed
    We use output of `git --version` to determine if we can run some tests
    that rely on features from newer git versions. Usually, we expect the
    output to be like:
    
        git version 2.17.2
    
    On some platforms, like MacOS, there could be a suffix after the version
    string, so that it looks something like:
    
        git version 2.17.2 (Apple Git-113)
    
    This causes things to fail like so:
    
        ValueError: invalid literal for int() with base 10: '2 (Apple Git-113)\n'
    
    Fix logic around `HAVE_OLD_GIT` such that we split the output of
    `git --version` without limit on how many times we split. Previously we
    used to split only twice so the suffixes like `(Apple Git-113)` are not
    part of the parsed version.
    dd791373
  • Chandan Singh's avatar
    Merge branch 'chandan/fix-git-version-mac' into 'master' · 96c0fbd6
    Chandan Singh authored
    testutils/site.py: Support parsing more exotic git versions
    
    See merge request !1118
    96c0fbd6
Loading
Loading