Commits on Source 4
-
As someone coming from GitHub to GitLab, I was pleasantly surprised by the 'filter by WIP status' option. To make sure we get the most out of it, add a guideline to keep the filter clean, to reduce reviewer burden.
-
I was recently surprised that we don't prefer addressing review comments in 'fixup!' commits. Coming from GitHub, I've found that fixup commits make it easier for reviewers to see what has changed since their last review. The idea is to use '--autosquash' before landing to clean up the history again. It's a pleasant surprise that it's easy to keep track of what changed in merge-requests between pushes, so we can always keep the history clean. Document this, so folks like me can see the light sooner.
-
Explain why it's useful to mention the decisions made for a change and provide links for background, e.g. issue numbers. My general experience of git histories is that folks don't do enough explaining, so it's great we have a contributing section for it. I've found it's easier for folks to stick to rules when they know the practical reasons for them, so provide some.
-
Angelos Evripiotis authored
Add more to GitLab-relevant parts of contributing See merge request !935
