NEWS

@@ -2,6 +2,10 @@
 buildstream 1.3.1
 =================
 
+  o BREAKING CHANGE: Default strip-commands have been removed as they are too
+    specific. Recommendation is if you are building in Linux is to use the
+    ones begin used in freedesktop-sdk project, for example
+
   o All elements must now be suffixed with `.bst`
     Attempting to use an element that does not have the `.bst` extension,
     will result in a warning.

buildstream/data/projectconfig.yaml

@@ -44,38 +44,8 @@ variables:
   # Indicates the build installation directory in the sandbox
   install-root: /buildstream-install
 
-  # Arguments for tooling used when stripping debug symbols
-  objcopy-link-args: --add-gnu-debuglink
-  objcopy-extract-args: |
-
-    --only-keep-debug --compress-debug-sections
-
-  strip-args: |
-
-    --remove-section=.comment --remove-section=.note --strip-unneeded
-
-  # Generic implementation for stripping debugging symbols
-  strip-binaries: |
-
-    cd "%{install-root}" && find -type f \
-      '(' -perm -111 -o -name '*.so*' \
-          -o -name '*.cmxs' -o -name '*.node' ')' \
-      -exec sh -ec \
-      'read -n4 hdr <"$1" # check for elf header
-       case "$1" in
-         %{install-root}%{debugdir}/*)
-           exit 0
-           ;;
-       esac
-       if [ "$hdr" != "$(printf \\x7fELF)" ]; then
-           exit 0
-       fi
-       debugfile="%{install-root}%{debugdir}/$1"
-       mkdir -p "$(dirname "$debugfile")"
-       objcopy %{objcopy-extract-args} "$1" "$debugfile"
-       chmod 644 "$debugfile"
-       strip %{strip-args} "$1"
-       objcopy %{objcopy-link-args} "$debugfile" "$1"' - {} ';'
+  # You need to override this with the commands specific for your system
+  strip-binaries: ""
 
   # Generic implementation for reproducible python builds
   fix-pyc-timestamps: |
@@ -196,4 +166,4 @@ shell:
 
   # Command to run when `bst shell` does not provide a command
   #
-  command: [ 'sh', '-i' ]
\ No newline at end of file
+  command: [ 'sh', '-i' ]

buildstream/plugins/elements/autotools.py

@@ -51,6 +51,14 @@ Here is the default configuration for the ``autotools`` element in full:
   .. literalinclude:: ../../../buildstream/plugins/elements/autotools.yaml
      :language: yaml
 
+.. note::
+
+   The `strip-binaries` variable is by default **empty**. You need to use the
+   appropiate commands depending of the system you are building.
+   If you are targetting Linux, ones known to work are the ones used by the
+   `freedesktop-sdk <https://freedesktop-sdk.io/>`_, you can take a look to them in their
+   `project.conf <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/freedesktop-sdk-18.08.21/project.conf#L74>`_
+
 See :ref:`built-in functionality documentation <core_buildelement_builtins>` for
 details on common configuration options for build elements.
 """

buildstream/plugins/elements/cmake.py

@@ -50,6 +50,14 @@ Here is the default configuration for the ``cmake`` element in full:
   .. literalinclude:: ../../../buildstream/plugins/elements/cmake.yaml
      :language: yaml
 
+.. note::
+
+   The `strip-binaries` variable is by default **empty**. You need to use the
+   appropiate commands depending of the system you are building.
+   If you are targetting Linux, ones known to work are the ones used by the
+   `freedesktop-sdk <https://freedesktop-sdk.io/>`_, you can take a look to them in their
+   `project.conf <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/freedesktop-sdk-18.08.21/project.conf#L74>`_
+
 See :ref:`built-in functionality documentation <core_buildelement_builtins>` for
 details on common configuration options for build elements.
 """

buildstream/plugins/elements/distutils.py

@@ -27,6 +27,14 @@ The distutils default configuration:
   .. literalinclude:: ../../../buildstream/plugins/elements/distutils.yaml
      :language: yaml
 
+.. note::
+
+   The `strip-binaries` variable is by default **empty**. You need to use the
+   appropiate commands depending of the system you are building.
+   If you are targetting Linux, ones known to work are the ones used by the
+   `freedesktop-sdk <https://freedesktop-sdk.io/>`_, you can take a look to them in their
+   `project.conf <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/freedesktop-sdk-18.08.21/project.conf#L74>`_
+
 See :ref:`built-in functionality documentation <core_buildelement_builtins>` for
 details on common configuration options for build elements.
 """

buildstream/plugins/elements/make.py

@@ -32,6 +32,14 @@ Here is the default configuration for the ``make`` element in full:
   .. literalinclude:: ../../../buildstream/plugins/elements/make.yaml
      :language: yaml
 
+.. note::
+
+   The `strip-binaries` variable is by default **empty**. You need to use the
+   appropiate commands depending of the system you are building.
+   If you are targetting Linux, ones known to work are the ones used by the
+   `freedesktop-sdk <https://freedesktop-sdk.io/>`_, you can take a look to them in their
+   `project.conf <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/freedesktop-sdk-18.08.21/project.conf#L74>`_
+
 See :ref:`built-in functionality documentation <core_buildelement_builtins>` for
 details on common configuration options for build elements.
 """

buildstream/plugins/elements/makemaker.py

@@ -27,6 +27,14 @@ The MakeMaker default configuration:
   .. literalinclude:: ../../../buildstream/plugins/elements/makemaker.yaml
      :language: yaml
 
+.. note::
+
+   The `strip-binaries` variable is by default **empty**. You need to use the
+   appropiate commands depending of the system you are building.
+   If you are targetting Linux, ones known to work are the ones used by the
+   `freedesktop-sdk <https://freedesktop-sdk.io/>`_, you can take a look to them in their
+   `project.conf <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/freedesktop-sdk-18.08.21/project.conf#L74>`_
+
 See :ref:`built-in functionality documentation <core_buildelement_builtins>` for
 details on common configuration options for build elements.
 """

buildstream/plugins/elements/manual.py

@@ -27,6 +27,15 @@ The empty configuration is as such:
   .. literalinclude:: ../../../buildstream/plugins/elements/manual.yaml
      :language: yaml
 
+.. note::
+
+   The `strip-binaries` variable is by default **empty**. You need to use the
+   appropiate commands depending of the system you are building.
+   If you are targetting Linux, ones known to work are the ones used by the
+   `freedesktop-sdk <https://freedesktop-sdk.io/>`_, you can take a look to them in their
+   `project.conf <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/freedesktop-sdk-18.08.21/project.conf#L74>`_
+
+
 See :ref:`built-in functionality documentation <core_buildelement_builtins>` for
 details on common configuration options for build elements.
 """

buildstream/plugins/elements/meson.py

@@ -47,6 +47,14 @@ Here is the default configuration for the ``meson`` element in full:
   .. literalinclude:: ../../../buildstream/plugins/elements/meson.yaml
      :language: yaml
 
+.. note::
+
+   The `strip-binaries` variable is by default **empty**. You need to use the
+   appropiate commands depending of the system you are building.
+   If you are targetting Linux, ones known to work are the ones used by the
+   `freedesktop-sdk <https://freedesktop-sdk.io/>`_, you can take a look to them in their
+   `project.conf <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/freedesktop-sdk-18.08.21/project.conf#L74>`_
+
 See :ref:`built-in functionality documentation <core_buildelement_builtins>` for
 details on common configuration options for build elements.
 """

buildstream/plugins/elements/modulebuild.py

@@ -27,6 +27,14 @@ The modulebuild default configuration:
   .. literalinclude:: ../../../buildstream/plugins/elements/modulebuild.yaml
      :language: yaml
 
+.. note::
+
+   The `strip-binaries` variable is by default **empty**. You need to use the
+   appropiate commands depending of the system you are building.
+   If you are targetting Linux, ones known to work are the ones used by the
+   `freedesktop-sdk <https://freedesktop-sdk.io/>`_, you can take a look to them in their
+   `project.conf <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/freedesktop-sdk-18.08.21/project.conf#L74>`_
+
 See :ref:`built-in functionality documentation <core_buildelement_builtins>` for
 details on common configuration options for build elements.
 """

buildstream/plugins/elements/pip.py

@@ -27,6 +27,14 @@ The pip default configuration:
   .. literalinclude:: ../../../buildstream/plugins/elements/pip.yaml
      :language: yaml
 
+.. note::
+
+   The `strip-binaries` variable is by default **empty**. You need to use the
+   appropiate commands depending of the system you are building.
+   If you are targetting Linux, ones known to work are the ones used by the
+   `freedesktop-sdk <https://freedesktop-sdk.io/>`_, you can take a look to them in their
+   `project.conf <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/freedesktop-sdk-18.08.21/project.conf#L74>`_
+
 See :ref:`built-in functionality documentation <core_buildelement_builtins>` for
 details on common configuration options for build elements.
 """

buildstream/plugins/elements/qmake.py

@@ -27,6 +27,14 @@ The qmake default configuration:
   .. literalinclude:: ../../../buildstream/plugins/elements/qmake.yaml
      :language: yaml
 
+.. note::
+
+   The `strip-binaries` variable is by default **empty**. You need to use the
+   appropiate commands depending of the system you are building.
+   If you are targetting Linux, ones known to work are the ones used by the
+   `freedesktop-sdk <https://freedesktop-sdk.io/>`_, you can take a look to them in their
+   `project.conf <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/freedesktop-sdk-18.08.21/project.conf#L74>`_
+
 See :ref:`built-in functionality documentation <core_buildelement_builtins>` for
 details on common configuration options for build elements.
 """