Abderrahim Kitouni authored Jan 27, 2019 and Javier Jardón committed Feb 08, 2019

the code for initializing remotes added the project specific remote
caches to the global list instead of making a copy.

Fixes #618

Abderrahim Kitouni authored Jan 28, 2019 and Javier Jardón committed Feb 08, 2019

This makes a junction use the artifact cache of the parent project
before the ones defined for the junction

Fixes #401

Use artifact cache specs from the parent project before those defined in junctions

Closes #618 and #401

See merge request !1113

Javier Jardón authored Feb 08, 2019 and Jürg Billeter committed Feb 09, 2019

Fedora 27 is EOL since 2018-11-30

See https://fedoraproject.org/wiki/End_of_life

.gitlab-ci.yml: Remove testing on Fedora 27

See merge request !1136

Fixes #662.

import.py: Validate config node

Closes #662

See merge request !1141

isdir() follows symlinks on the host, resulting in potential host
contamination. This change reorders the file checks to avoid this issue.

This is required to ensure symlinks are not resolved on the host.

list_dirs was always True in the BuildStream code base. There was also a
bug in the list_dirs=False code path as it did not return symlinks in
`dirnames`.

This is an API break, however, there are no known external callers.

os.walk() resolves symlinks to check whether they point to a directory
even when followlinks is set to False. We already work around that
broken behavior by extracting symlinks from `dirnames`. However, the
sort order was still incorrect as we returned symlinks in dirnames
before files and other symlinks. This change fixes this, sorting all
files and symlinks in a single list.

This matches the change in utils.list_relative_paths() that now sorts
all symlinks as files, instead of following the broken behavior of
os.walk().

Symlink fixes

See merge request !1138

Angelos Evripiotis authored Feb 05, 2019 and Jürg Billeter committed Feb 11, 2019

Replace the instructions for pyflame+flamegraph with simpler ones for
snakeviz. For our general use-case this seems to be easier and better.
Usage of this tool was demonstrated at the 2019 BuildStream Gathering in
January by Daniel Silverstone, when presenting the aggregate results of
profiling on many target environments.

Here is the relevant mailing list thread:

"Profiling before the gathering"
https://mail.gnome.org/archives/buildstream-list/2019-January/msg00057.html

contributing: snakeviz replaces pyflame+flamegraph

See merge request !1129

Angelos Evripiotis authored Oct 23, 2018 and Jürg Billeter committed Feb 11, 2019

Use the provenance of the include block, instead of the whole node.

Angelos Evripiotis authored Oct 23, 2018 and Jürg Billeter committed Feb 11, 2019

Previously, a missing include would result in an error like this:

    Could not find file at not-a-file.include

Note that the file containing the include was not mentioned.

Now we get an error like this instead:

    element.bst [line 7 column 5]: Include block references a file that
    could not be found: 'not-a-file.include'.

Angelos Evripiotis authored Oct 23, 2018 and Jürg Billeter committed Feb 11, 2019

Previously, include a directory result in an error like this:

    mydir is a directory. bst command expects a .bst file.

Note that the file containing the include was not mentioned.

Now we get an error like this instead:

    element.bst [line 12 column 0]: Include block references a
    directory instead of a file: 'mydir'.

Angelos Evripiotis authored Oct 23, 2018 and Jürg Billeter committed Feb 11, 2019

Avoid an unnecessary call to os.path.join().

Angelos Evripiotis authored Feb 06, 2019 and Jürg Billeter committed Feb 11, 2019

Don't create and remove temp dirs unnecessarily when they are not used,
looks like these were just copy-pastes without intended side-effects.

More user-friendly reporting on include errors

See merge request !891