Chandan Singh authored Dec 29, 2018 and Chandan Singh committed Jan 02, 2019

https://github.com/sphinx-doc/sphinx/issues/4375 has been closed as
`wontfix`. Update the comment in doc/Makefile that mentions it, based on
the discussion on the issue.

doc/Makefile: Update comment about sphinx entrypoint

See merge request !1026

We need to bump the testsuite image versions to use the new
pycodestyle update that allows excluding file paths, so that we can
exclude generated python code.

Javier Jardón authored Aug 10, 2018 and Tristan Maat committed Jan 02, 2019

pep8 package was renamed to pycodestyle to reduce confusion.

Disabled warnings:
W504 - Line break after binary operator (seems people like this)
W605 - Invalid escape sequence (some of our regexes use these)

Use pycodestyle instead pep8 python module

See merge request !638

Add `.in` and `.txt` requirements files for BuildStream's pure python
dependencies. For each pair, the `.in` file is supposed to capture the
loose version requirements, and the corresponding `.txt` file is
supposed to have frozen requirements. We have 3 such sets:

* `requirements`: BuildStream's runtime dependencies
* `dev-requirements`: Dependencies for running tests
* `plugin-requirements`: Dependencies for core plugins

Note that the frozen requirements files will only be used for testing
purposes, and `setup.py` will continue to read loose requirements.

Add `tox.ini` file that will enable us to use
[tox](https://tox.readthedocs.io/) as a frontend for running tests.
Since we share the config via `setup.cfg` and requirements via
requirements files, commands like `python3 setup.py test` will continue
to work.

Instead of invoking tests throung `setup.py`, use `tox` as a frontend in
the CI pipelines.

Since we don't allow use of site packages by default in our `tox`
configuration, people will need to install non-python build dependencies
of some of our dependencies that do not provide pre-built wheels. We
have two such packages at the moment:

* psuitl: requires python C headers, compiler
* pygobject: requires python C headers, pkg-config, compiler, cairo
  headers, and gobject libraries

These new `.in` and `.txt` are making the repository look very
cluttered. Move them to a separate `tools` directory to make it look a
bit cleaner.

Currently the CI and the docs both have to duplicate the same inforation
about how to gather dependencies etc, and have to use hacky ways to run
them.

Add a new `docs` environment to our tox setup so that building docs is
as simple as running `tox -e docs`.

When we update our dependencies, developers will eventually need to
recreate their `tox` environments to get correct results. This happens
because `tox` isn't particularly good at recognizing changes in the
requirements files.

Use tox as a frontend for running tests

See merge request !1027

Chandan Singh authored Jan 03, 2019 and Chandan Singh committed Jan 03, 2019

In !1028, we added a test specifically to test
that BuildStream correctly raises an warning when the name of an element
contains characters that are invalid on Windows. Unfortunately, we
didn't see it coming that it would make it impossible to checkout this
branch on Windows.

Fix it by generating this file, only if we are not running on Windows.

* tests/testutils/site.py: Add `IS_WINDOWS` check
* tests/frontend/buildcheckout.py: Generate file with invalid filename
  on the fly
* Remove tests/frontend/project/elements/invalid-chars.

Fixes #842.

Note that this may still cause issues on WSL when running tests on a
shared filesystem, but that seems to be a generic issue on WSL with
`os.rename`.

tests/frontend/buildcheckout.py: Fix bad filename issue for Windows

Closes #842

See merge request !1032

This should save us some cycles in CI, and also allow the
developer to more conveniently lint separately from testing.

Apparently you need to spell Jinja2 with a capital J, otherwise
we find it listed twice in the resulting requirements.txt files.

We no longer run the linters through pytest, so we don't need these
plugins anymore.

Run the linter separately from the tests

See merge request !1033

Tom Coldrick authored Dec 20, 2018 and Tristan Van Berkom committed Jan 03, 2019

In _yaml.py and _frontend/complete.py we were getting pylint warnings
for using collections.Mapping and collections.Iterable, which are
abstract classes now provided from collections.abc. This patch just
uses the classes from the right place.

Use collections.abc for Mapping, Iterable

Closes #831

See merge request !1020

Moving fetch and track to the source command group accidentally dropped
the support for guessing targets for these commands when invoked from a
workspace directory. This brings it back.

_frontend/cli.py: Reinstate support for guessing targets

See merge request !1036

Valentin David authored Dec 20, 2018 and Valentin David committed Jan 04, 2019

Fixes #631.

Valentin David authored Dec 20, 2018 and Valentin David committed Jan 04, 2019

Fixes #780.