James Ennis authored Nov 07, 2018 and Javier Jardón committed Nov 08, 2018

This patch partially resolves #700

James Ennis authored Nov 08, 2018 and Javier Jardón committed Nov 08, 2018

Due to the changed Exception message, this patch also changes
the test_parse_size_over_1024T test in misc.py

Add local cache expiry documentation and fix misleading error message when specifying a percentage cache quota

Closes #700

See merge request !939

Benjamin Schubert authored Nov 07, 2018 and Benjamin Schubert committed Nov 09, 2018

According to the documentation
(https://www.unix.com/man-page/POSIX/3posix/rename/), when the directory
already is there, either EEXIST or ENOTEMPTY could be thrown.

Previously only ENOTEMPTY was checked.

Done:
  - Separated the move into its own function
  - Check for both errors
  - Create unit tests for it, covering most test cases

Benjamin Schubert authored Nov 09, 2018 and Benjamin Schubert committed Nov 09, 2018

Moving atomically a file/directory can be tricky since different
errors might be raised for the same underlying problem.

Having a utility function to reduce this discrepancies will help
in ensuring we have correct behavior