560a634256839de4c9e8bcc41215a17c525d0e61 to b848172c518d3d52a94feded9e12a0b69a27f1d7 · BuildStream / buildstream

Commits on Source 5

_loader/loader.py: Refactor warnings about element names in one method · 8a020a5a

Chandan Singh authored Dec 30, 2018 and

Tristan Van Berkom committed Dec 31, 2018

Currently we some duplication in the way we check for invalid filenames.
To make it more robust and allow room for adding more warnings, refactor
it into a separate method `_warn_invalid_elements()` that handles just
this.

8a020a5a

_loader/loader.py: Add warnings about invalid characters in filename · 87568074
Chandan Singh authored Dec 30, 2018 and Tristan Van Berkom committed Dec 31, 2018
```
See https://mail.gnome.org/archives/buildstream-list/2018-December/msg00061.html
for some related discussion.
```
87568074
tests/buildcheckout.py: Add tests for invalid chars in filename · 4b2992c1
Chandan Singh authored Dec 31, 2018 and Tristan Van Berkom committed Dec 31, 2018

4b2992c1
doc: Add note about valid element names · ce9e9c2d
Chandan Singh authored Dec 30, 2018 and Tristan Van Berkom committed Dec 31, 2018

ce9e9c2d
Merge branch 'chandan/element-filename-requirements' into 'master' · b848172c
Tristan Van Berkom authored Dec 31, 2018
```
Add warnings about invalid characters in filename

See merge request !1028
```
b848172c