This ensures that option expressions are resolved in the project
level overrides before attempting to composite them on the instantiated
elements. Seems this is a regression from introducing the include
directive.

This fixes issue #658

This is a regression test for issue #658

Fix override options

Closes #658

See merge request !802

Since ArtifactCache.setup_remotes() can be expensive and should only
happen once, this commit will assert() if it is called a second time
on an artifact cache instance.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

The initialization of remotes is done by ArtifactCache.setup_remotes()
and as such it was wrong for these tests to be calling
CASCache.initialize_remotes() a second time.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

The SandboxRemote used to construct its own CASCache which was
considered dangerous.  This patch replaces that with acquisition of
the cache via the Platform singleton, hopefully eliminating issues
from having more than one artifact cache object in a single process.

Signed-off-by: Daniel Silverstone <daniel.silverstone@codethink.co.uk>

sandbox/_sandboxremote.py: Acquire cache via Platform

See merge request !797

When configuring a push remote and specifying either the client-cert
or the client-key, then both must be specified. This ensures we
get an informative error instead of a stack trace and BUG.

Fixes issue #625

Test that we get the expected error when configuring a client-cert
without client-key, or the inverse.

Fix artifact config crash

Closes #625

See merge request !804

richardmaw-codethink authored Sep 04, 2018 and Tristan Van Berkom committed Sep 18, 2018

This fixes all devices being mapped to the non-existant device 0,
which prevents being able to use even safe devices like /dev/null
through the hardlinks FUSE layer.

richardmaw-codethink authored Sep 04, 2018 and Tristan Van Berkom committed Sep 18, 2018

This is needed to permit access to the device nodes added to /dev
on Linux when FUSE is used as root.

The chroot sandbox only works with all privileges,
so there's no explicit check for being root
or having the appropriate capabilities.

A check for whether it's running as root isn't needed on Linux with bubblewrap
because /dev or its devices are mounted on top of the FUSE layer,
so device nodes are accessed directly rather than through the FUSE layer.

fix chroot sandbox devices

See merge request !781

bst build returns "missing project.conf" when a project.conf is invalid
This results in an existing project with malformed yaml being dismissed
and attempts to make a new project

Added new exception

Incorrect error when malformed project.conf

Closes #642

See merge request !792

The SKIPPED message type is now used to indicate the end of a task which
was successful without having to perform the given task.

This overhauls the use of `Queue.done()` and therefore queues do not
need to provide a processed/skipped return value from `done()`. Instead
this is replaced with the action of raising a `SkipJob` exception from
within `Queue.process()`.

Adds a test to ensure that BuildStream alerts the user of a skipped push
when the remote already has the artifact cached.

This removes the timed_activity for an element _push action. This is
unnecessary as the job is already being timed elsewhere.

Pulled/Pushed messages will no longer be produced from within
element.py, instead they will be produced during CasCache push() and
pull() appropriately.

Message consistency has also been improved.

Both pulling and pushing INFO messages are now status messages.

Calls to the messaging API through `self.context.message()` have now
been switched to `element.info`.

Add SkipJob for indicating a skipped activity

See merge request !765

Tristan Van Berkom authored Sep 19, 2018 and Tristan Van Berkom committed Sep 19, 2018

This actually improves reliability of the status bar because we
now disable it completely in the case that not all of the terminal
escape sequences are supported on the given terminal.

This replaces the few functions we were using, to move the cursor
up one line, move it to the beginning of the line, and to clear a
line, with low level functions provided by the curses module in
the standard library.

This change makes it easier for downstream distro package maintainers
to package BuildStream, particularly on Fedora.

Asides from changing _frontend/status.py, this commit includes the
following changes:

  * _frontend/app.py: Use python isatty() function to determine if
                      we are connected to a tty, instead of relying
		      on blessings.

  * setup.py: Remove the dependency on blessings.

_frontend/status.py: Completely remove the blessings dependency from BuildStream

See merge request !808

Fix rst link formatting for guideline links

See merge request !811

This is benign because a _yaml.ChainMap doesn't raise a
KeyError, but it's not required to be a ChainMap.

Note that the ProvenanceFile's names will be incorrect after loading
from the cache, but this is currently only used for writeback, which
isn't used in junctions.