00c4794d3536ea2b10049342cc0d3ecb777046a6 to ce9e9c2dbec71841d5ac5311f6d18ffb78bce9d3 · BuildStream / buildstream

Commits on Source 7

tests/loader/junctions.py: Use Result checking APIs instead of manually · a080b6c7
Tristan Van Berkom authored Dec 31, 2018
```
Better to use the same API everywhere for thecking CLI results.
```
a080b6c7
tests/loader/junctions.py: Test the error we expect when a cross junction element is not found · d7c8b54d
Tristan Van Berkom authored Dec 31, 2018

d7c8b54d
Merge branch 'tristan/junction-tests' into 'master' · 560a6342
Tristan Van Berkom authored Dec 31, 2018
```
Junction test addition

See merge request !1029
```
560a6342

_loader/loader.py: Refactor warnings about element names in one method · 8a020a5a

Chandan Singh authored Dec 30, 2018 and

Tristan Van Berkom committed Dec 31, 2018

Currently we some duplication in the way we check for invalid filenames.
To make it more robust and allow room for adding more warnings, refactor
it into a separate method `_warn_invalid_elements()` that handles just
this.

8a020a5a

_loader/loader.py: Add warnings about invalid characters in filename · 87568074
Chandan Singh authored Dec 30, 2018 and Tristan Van Berkom committed Dec 31, 2018
```
See https://mail.gnome.org/archives/buildstream-list/2018-December/msg00061.html
for some related discussion.
```
87568074
tests/buildcheckout.py: Add tests for invalid chars in filename · 4b2992c1
Chandan Singh authored Dec 31, 2018 and Tristan Van Berkom committed Dec 31, 2018

4b2992c1
doc: Add note about valid element names · ce9e9c2d
Chandan Singh authored Dec 30, 2018 and Tristan Van Berkom committed Dec 31, 2018

ce9e9c2d