fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Add reverse dependencies in the LoadElement

buildstream/_loader/loader.py

@@ -441,8 +441,6 @@ class Loader():
             meta_element = element._loader._collect_element(element)
             element.visit(meta_element)
 
-            visited_elements = []
-
             for dep in sorted(element.dependencies, key=cmp_to_key(compare_unprocessed), reverse=True):
                 if dep.dep_type != Symbol.RUNTIME:
                     dep.element.on_visit(meta_element.build_dependencies.append)
@@ -454,9 +452,7 @@ class Loader():
                     # it as soon as possible
                     elements_to_load.append(dep.element)
                 else:
-                    visited_elements.append(dep.element)
-
-            elements_to_load.extendleft(visited_elements)
+                    elements_to_load.appendleft(dep.element)
 
         for element in self._meta_elements.values():
             element.build_dependencies.sort(key=attrgetter("index"), reverse=True)