WIP: notes

buildstream/_scheduler/queues/fetchqueue.py

@@ -44,6 +44,7 @@ class FetchQueue(Queue):
 
     def status(self, element):
         # state of dependencies may have changed, recalculate element state
+        # FIXME: we should never be doing this
         element._update_state()
 
         if not element._is_required():

buildstream/_scheduler/queues/pullqueue.py

@@ -39,6 +39,7 @@ class PullQueue(Queue):
 
     def status(self, element):
         # state of dependencies may have changed, recalculate element state
+        # FIXME: this should never be needed
         element._update_state()
 
         if not element._is_required():

buildstream/element.py

@@ -1448,6 +1448,7 @@ class Element(Plugin):
     # This unblocks pull/fetch/build.
     #
     def _set_required(self):
+        # FIXME: this should enqueue stuff in the queue, it should not be here by default
         if self.__required:
             # Already done
             return
@@ -1458,6 +1459,7 @@ class Element(Plugin):
         for dep in self.dependencies(Scope.RUN, recurse=False):
             dep._set_required()
 
+        # FIXME: this should not be done at all here
         self._update_state()
 
     # _is_required():