Commit bd1196ef authored by Ed Baunton's avatar Ed Baunton
Browse files

Provide explicit reason for SourceError exception on path 

When the user provides a path for the filename parameter, provide a reason
parent c049d021

buildstream/plugins/sources/remote.py

+2 −1
Original line number Diff line number Diff line
@@ -62,7 +62,8 @@ class RemoteSource(DownloadableFileSource): 
        self.filename = self.node_get_member(node, str, 'filename', os.path.basename(self.url))



        if os.sep in self.filename:

            raise SourceError('{}: filename parameter cannot contain directories'.format(self))

            raise SourceError('{}: filename parameter cannot contain directories'.format(self),

                              reason="filename-contains-directory")

        self.node_validate(node, DownloadableFileSource.COMMON_CONFIG_KEYS + ['filename'])



    def get_unique_key(self):

tests/sources/remote.py

+1 −1
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ def test_path_in_filename(cli, tmpdir, datafiles): 
    ])



    # The bst file has a / in the filename param

    result.assert_main_error(ErrorDomain.SOURCE, None)

    result.assert_main_error(ErrorDomain.SOURCE, "filename-contains-directory")





@pytest.mark.datafiles(os.path.join(DATA_DIR, 'single-file'))