Commit 4cfabce8 authored by Angelos Evripiotis's avatar Angelos Evripiotis Committed by Tristan Van Berkom
Browse files

BREAK: manual.yaml: don't set any default env vars

Remove the 'MAKEFLAGS' and 'V' defaults.

Now that there is a specialised 'make' element, these make-specific
defaults don't make sense here. This element is meant to be a blank
slate for folks to build on.

Note that this is a breaking change, that will require some users to
make changes to their .bst files if they are expecting these environment
variable to be set.

_versions.py: BST_FORMAT_VERSION bumped to 18.

This fixes issue #718
parent 89ace5d7
Loading
Loading
Loading
Loading
Loading
+6 −0
Original line number Diff line number Diff line
@@ -2,6 +2,12 @@
buildstream 1.3.1
=================

  o BREAKING CHANGE: The 'manual' element lost its default 'MAKEFLAGS' and 'V'
    environment variables. There is already a 'make' element with the same
    variables. Note that this is a breaking change, it will require users to
    make changes to their .bst files if they are expecting these environment
    variables to be set.

  o Failed builds are included in the cache as well.
    `bst checkout` will provide anything in `%{install-root}`.
    A build including cached fails will cause any dependant elements
+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@
# This version is bumped whenever enhancements are made
# to the `project.conf` format or the core element format.
#
BST_FORMAT_VERSION = 17
BST_FORMAT_VERSION = 18


# The base BuildStream artifact version
+0 −19
Original line number Diff line number Diff line
# No variables added for the manual element by default, set
# this if you plan to use make, and the sources cannot handle
# parallelization.
#
# variables:
#
#   notparallel: True

# Manual build element does not provide any default
# build commands
config:
@@ -28,14 +20,3 @@ config:
  strip-commands:
  - |
    %{strip-binaries}

# Use max-jobs CPUs for building and enable verbosity
environment:
  MAKEFLAGS: -j%{max-jobs}
  V: 1

# And dont consider MAKEFLAGS or V as something which may
# affect build output.
environment-nocache:
- MAKEFLAGS
- V