## Summary [//]: # (Summarize the bug encountered concisely) When deliberately inducing a build failure by invoking `'false'`, I find that the error message is a red herring: Directory '/buildstream-install' was not found inside the sandbox, unable to collect artifact contents ## Steps to reproduce [//]: # (How one can reproduce the issue - this is very important) - Follow the excellent [running commands tutorial](https://docs.buildstream.build/tutorial/running-commands.html) to setup a vanilla build project. - Follow the BuildStream instructions in the readme of this [buildgrid.hub.docker.com merge-request](https://gitlab.com/BuildGrid/buildgrid.hub.docker.com/merge_requests/1) to get BuildGrid running locally. Note that you probably want to put the remote config in your `project.conf`: ```yaml artifacts: url: http://localhost:50052 push: true remote-execution: execution-service: url: http://localhost:50051 action-cache-service: url: http://localhost:50052 storage-service: url: http://localhost:50052 client-key: '' client-cert: '' server-cert: '' ``` First, verify that you can `bst build hello.bst` without any errors, watch for lines like this to know it was remote: ``` [--:--:--][31d226f1][build:hello.bst ] START Waiting for the remote build to complete [00:00:02][31d226f1][build:hello.bst ] SUCCESS Waiting for the remote build to complete ``` Next, apply a patch to make the build fail: ```patch diff --git a/elements/hello.bst b/elements/hello.bst index 4eb17d8..163948b 100644 --- a/elements/hello.bst +++ b/elements/hello.bst @@ -16,6 +16,8 @@ sources: config: build-commands: + - mkdir -p "%{install-root}" + - 'false' - make PREFIX="%{prefix}" install-commands: ``` ## What is the current bug behavior? [//]: # (What actually happens) The error message is unrelated to the error, furthermore it seems to be complaining about a directory that does exist not existing. ``` [--:--:--] START : Waiting for the remote build to complete [00:00:03] SUCCESS: Waiting for the remote build to complete [--:--:--] START hello.bst: Caching artifact [00:00:00] FAILURE hello.bst: Caching artifact [00:00:23] FAILURE hello.bst: Directory '/buildstream-install' was not found inside the sandbox, unable to collect artifact contents ``` ## What is the expected correct behavior? [//]: # (What you should see instead) Something more like this: ``` [--:--:--] START hello.bst: Running build-commands [--:--:--] STATUS hello.bst: Running command false [00:00:00] FAILURE hello.bst: Running build-commands [--:--:--] START hello.bst: Caching artifact [00:00:00] SUCCESS hello.bst: Caching artifact [00:00:03] FAILURE hello.bst: Command failed with exitcode 1 false ``` or at least something that indicates a command failed. ## Relevant logs and/or screenshots [//]: # (Paste any relevant logs - please use code blocks ``` to format console output, logs, and code as it's hard to read otherwise. You can also add a Snippet and link it here. Check the markdown giude on Gitlab for further tips) ## Possible fixes [//]: # (If you can, link to the line of code that might be responsible for the problem) Perhaps this MR from @jmacarthur will help? Note that in the repro we deliberately create `"%{install-root}"` though, perhaps it is already too late. - ["sandboxremote.py: Create marked directories before running"](https://gitlab.com/BuildStream/buildstream/merge_requests/1056) ## Other relevant information [//]: # (Add the BuildStream version. Substitute below the "x" by "1", "2" or the right version. Add more than one version if necessary) This seems related to me, but not the same: - ["Remote Execution: Don't ignore stdout and stderr"](https://gitlab.com/BuildStream/buildstream/issues/797), this would also help. ----