Skip to content

overlap-whitelist tests paths without the leading /

Summary

The overlap-whitelist property seems not to work. On closer inspections, it does work but I cannot use the %{prefix} variable because the paths buildstream tests don't have a leading slash.

I suppose this is a bug because the documentation is using the leading slash.

Steps to reproduce

I'm using the following overlap-whitelist https://gitlab.gnome.org/GNOME/gnome-build-meta/blob/c5f9311c24d9ebc29991206bd6f4e13bf9bbebdc/elements/sdk/gtk+.bst#L31

What is the current bug behavior?

Buildstream is still reporting non-whitelisted overlaps. See https://gitlab.gnome.org/GNOME/gnome-build-meta/-/jobs/128446

What is the expected correct behavior?

the overlaps should be whitelisted.

Possible fixes

trying to print pattern from the __file_is_whitelisted function at https://gitlab.com/BuildStream/buildstream/blob/bst-1.2/buildstream/element.py#L2318, I see that the files are tested without the leading slash e.g. usr/share/gettext/its/gtkbuilder.its

Other relevant information

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information