This project is archived. Its data is read-only.

Improve logging in sandboxremote for UNAVAILABLE responses

Summary

Currently, the error message is simply "Failed contacting remote execution server at .".

This can mean a wide range of things and doesn't really narrow down the problem. In my case, the problem was due to the platform properties not matching the server deployment.

Steps to reproduce

Force an UNNAVAILABLE GRPC response from the remote execution server.

What is the current bug behavior?

"Failed contacting remote execution server at URL."

What is the expected correct behavior?

"Failed contacting remote execution server at URL: Internal GRPC error message"

Relevant logs and/or screenshots

https://gitlab.com/BuildStream/buildstream/-/jobs/718108839#L3472 is from a branch where I added temporary logging of the entire error.

Possible fixes

Decide an appropriate level of detail to report and append it to the format string.

https://gitlab.com/BuildStream/buildstream/-/blob/master/src/buildstream/sandbox/_sandboxremote.py#L218

Other relevant information

  • BuildStream version affected: master

Edited Sep 03, 2020 by Qinusty
Assignee Loading
Time tracking Loading