From 10f27f3f84dcbf03328193f5ae573f41bc74da01 Mon Sep 17 00:00:00 2001
From: Tristan Van Berkom <tristan.vanberkom@codethink.co.uk>
Date: Thu, 16 Aug 2018 16:52:54 +0900
Subject: [PATCH] _frontend/app.py: Notify session completions
Use the optionally implemented desktop notification method
to notify when a session completes.
Previously, this used to only notify when an interactive prompt
appears.
This is an attempt to fix #385
---
buildstream/_frontend/app.py | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/buildstream/_frontend/app.py b/buildstream/_frontend/app.py
index 5c13bf0bfc..1550fbcb31 100644
--- a/buildstream/_frontend/app.py
+++ b/buildstream/_frontend/app.py
@@ -269,6 +269,9 @@ class App():
else:
self._message(MessageType.FAIL, session_name, elapsed=elapsed)
+ # Notify session failure
+ self._notify("{} failed".format(session_name), "{}".format(e))
+
if self._started:
self._print_summary()
@@ -286,6 +289,9 @@ class App():
if self._started:
self._print_summary()
+ # Notify session success
+ self._notify("{} succeeded".format(session_name), "")
+
# init_project()
#
# Initialize a new BuildStream project, either with the explicitly passed options,
@@ -419,6 +425,12 @@ class App():
# Local Functions #
############################################################
+ # Local function for calling the notify() virtual method
+ #
+ def _notify(self, title, text):
+ if self.interactive:
+ self.notify(title, text)
+
# Local message propagator
#
def _message(self, message_type, message, **kwargs):
@@ -571,8 +583,8 @@ class App():
while choice not in ['continue', 'quit', 'terminate', 'retry']:
click.echo(summary, err=True)
- self.notify("BuildStream failure", "{} on element {}"
- .format(failure.action_name, element.name))
+ self._notify("BuildStream failure", "{} on element {}"
+ .format(failure.action_name, element.name))
try:
choice = click.prompt("Choice:", default='continue', err=True,
--
GitLab