Loading CONTRIBUTING.rst +8 −12 Original line number Original line Diff line number Diff line .. _contributing: .. _contributing: Contributing Contributing Loading Loading @@ -201,20 +200,17 @@ trunk. Committer access Committer access ---------------- ---------------- We'll hand out commit access to anyone who has successfully landed a single We'll hand out commit access to anyone who has successfully landed a patch to the code base. Please request this via Slack or the mailing list. patch to the code base. Please request this via Slack or the mailing list. This of course relies on contributors being responsive and show willingness to This of course relies on contributors being responsive and showing willingness to address problems after landing branches there should not be any problems here. address any problems that come about after landing branches. What we are expecting of committers here in general is basically to escalate the review in cases of uncertainty: - If the change is very trivial (obvious few line changes, typos…), and you are When submitting a patch, please obtain a review from another committer who is confident of the change, there is no need for review. familiar with the area of the code base which the branch effects. An approval - If the change is non trivial, please obtain a review from another committer from someone who is not the patch author will be needed before any merge (we use who is familiar with the area which the branch effects. An approval from gitlab's 'approval' feature for this). What we are expecting of committers here someone who is not the patch author will be needed before any merge. in general is basically to escalate the review in cases of uncertainty. .. note:: .. note:: Loading Loading
CONTRIBUTING.rst +8 −12 Original line number Original line Diff line number Diff line .. _contributing: .. _contributing: Contributing Contributing Loading Loading @@ -201,20 +200,17 @@ trunk. Committer access Committer access ---------------- ---------------- We'll hand out commit access to anyone who has successfully landed a single We'll hand out commit access to anyone who has successfully landed a patch to the code base. Please request this via Slack or the mailing list. patch to the code base. Please request this via Slack or the mailing list. This of course relies on contributors being responsive and show willingness to This of course relies on contributors being responsive and showing willingness to address problems after landing branches there should not be any problems here. address any problems that come about after landing branches. What we are expecting of committers here in general is basically to escalate the review in cases of uncertainty: - If the change is very trivial (obvious few line changes, typos…), and you are When submitting a patch, please obtain a review from another committer who is confident of the change, there is no need for review. familiar with the area of the code base which the branch effects. An approval - If the change is non trivial, please obtain a review from another committer from someone who is not the patch author will be needed before any merge (we use who is familiar with the area which the branch effects. An approval from gitlab's 'approval' feature for this). What we are expecting of committers here someone who is not the patch author will be needed before any merge. in general is basically to escalate the review in cases of uncertainty. .. note:: .. note:: Loading
