Runner: Stop inlining the contents of stdout/err in `ActionResult`s
Description
As mentioned in #50 (closed), inlining the contents of a command's stdout
/stderr
in the ActionResult
is something that depends on the request issued by a client in its GetActionResultRequest
.
This MR changes it so that Runner
stops inlining the contents of the standard outputs. The contents will be uploaded to CAS and their digests returned.
Changes proposed in this merge request:
-
Runner::executeAndStore()
: upload contents of stdout/err to CAS and populate theActionResult
'sstdout_digest
andstderr_digest
- Add
Runner::executeAndStore()
implementation receiving a callback to mock the upload function in unit tests - Update unit tests for the new behavior
- Remove unused parameter's names in
TestRunner::execute()
Note that this modifies the produced ActionResult
messages, so digests won't match. The e2e
test will need adjusting.
Closes #50 (closed)