Follow-up from "Create generic directory traversal method, introduce `buildboxcommon_direntwrapper`, and add support for `chmod`'ing directories."
The following discussion from !160 (merged) should be addressed:
-
@juergbi started a discussion: (+1 comment) Why do we ignore
fstaterrors? Anfstaterror seems very unlikely unlessfdis not a valid file descriptor. In that case an exception is definitely warranted, in my opinion.
TODO
-
Update FileUtils is_directoryto check for fstat errors. -
Use lstatinstead ofstatso symlinks aren't followed.