Compilation error and solution on High Sierra
Compilation fails on High Sierra.
Error:
CMake Error at heimdall-frontend/CMakeLists.txt:53 (install):
install TARGETS given no BUNDLE DESTINATION for MACOSX_BUNDLE executable
target "heimdall-frontend".
The issue is already fixed in this pull request that was not merged:
https://github.com/Benjamin-Dobell/Heimdall/pull/462
To get compilation to work before this is merged, manually patch heimdall-frontend/CMakeLists.txt with:
diff --git a/heimdall-frontend/CMakeLists.txt b/heimdall-frontend/CMakeLists.txt
index 05a9e75..6614a44 100644
--- a/heimdall-frontend/CMakeLists.txt
+++ b/heimdall-frontend/CMakeLists.txt
@@ -52,5 +52,6 @@ target_link_libraries(heimdall-frontend Qt5::Widgets)
target_link_libraries(heimdall-frontend z)
install (TARGETS heimdall-frontend
RUNTIME DESTINATION ${CMAKE_INSTALL_PREFIX}/bin
+ BUNDLE DESTINATION ${CMAKE_INSTALL_PREFIX}/bin
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR})
(Add the line BUNDLE DESTINATION ${CMAKE_INSTALL_PREFIX}/bin
where you see the +)