- 23 Feb, 2019 1 commit
-
-
Kevin J. McCarthy authored
On Arch, it is called docbook2text
-
- 21 Feb, 2019 1 commit
-
-
Andrey Skvortsov authored
Currently mutt truncates long filenames in attachments and doesn't take into account UTF-8 character size. If filename is truncated in the middle of multi-byte UTF-8 character (last character is bad), then some mail clients assume whole attachment name bad and don't display its name (use 'Noname' instead). Filenames can be up to 255 *characters* long depending on used filesystem. ReiserFS, NFTS, FAT, APFS and some other supports up to 255 characters. In the worst case 255 characters in UTF-8 will take 255*4 = 1020 bytes. Every non-ascii byte in the filename will be encoded using 3 bytes (for example, %8D). So 'Content-Disposition' will take in the worst case up to: 1020*3 = 3060 bytes. Therefore even LONG_STRING (1024) isn't enough.
-
- 13 Feb, 2019 4 commits
-
-
Kevin J. McCarthy authored
Abort if the value is not decodable.
-
Kevin J. McCarthy authored
Ticket #100 revealed that even a bufsize of 8192 isn't guaranteed to be big enough. Convert those large buffers to use the buffer pool instead.
-
Kevin J. McCarthy authored
Add mutt_buffer_from_base64() mutt_buffer_to_base64() to help with transitioning to buffers.
-
Kevin J. McCarthy authored
-
- 07 Feb, 2019 1 commit
-
-
Vincent Lefevre authored
-
- 06 Feb, 2019 3 commits
-
-
Kevin J. McCarthy authored
This function differs from <group-reply> only in that it preserves To recipients in the original email as To recipients in the reply. The merits of this function aren't without controversy; therefore it is left unbound by default. Those who care about such things are free to bind it. Combine reply operation handlers in the pager and curs_main, since the code was the same with the exception of the flags used.
-
Vincent Lefevre authored
-
Vincent Lefevre authored
-
- 02 Feb, 2019 2 commits
-
-
Kevin J. McCarthy authored
Don't allow the operation on a non-directory. Print a message indicating it's not a directory.
-
Kevin J. McCarthy authored
The i variable is used in several places and scopes as a temporary index variable, but is also used to record the current operation. Separate them out to make the code less confusing.
-
- 01 Feb, 2019 4 commits
-
-
Kevin J. McCarthy authored
-
Kevin J. McCarthy authored
-
Kevin J. McCarthy authored
-
Some (maybe most) IMAP mail systems allow folders to be nested inside folders, so you can have, say, an Inbox with more folders inside it. However, in the file browser, mutt will only open a maildir/mh directory as a mailbox, there is no way to get to the child mailboxes. This change adds a function <descend-directory> that forces mutt to descend into the directory. It is unbound by default. Signed-off-by:
Corey Minyard <minyard@acm.org>
-
- 25 Jan, 2019 2 commits
-
-
Kevin J. McCarthy authored
-
Kevin J. McCarthy authored
Commit 331d9d5a attempted to fix a problem with an attachment having extension .p7m. The attachment menu tried to decode and failed, and the part ended up being replaced by a bogus text/plain part. The problem is that crypt_smime_decrypt_mime() returns a text/plain part if the decode fails, meaning we can't distinguish failure from success in this case. As a compromise, only use a text/plain resulting from a single top-level application_smime part. This will allow for the case of an text/plain encoded email, but won't end up hiding attachments that were not decoded.
-
- 24 Jan, 2019 3 commits
-
-
Kevin J. McCarthy authored
Since changeset 2fd6f99b allows nested encryption handling, there is no need to deal with the nesting directly. Instead, just recursive as with other nested handling.
-
Kevin J. McCarthy authored
-
Kevin J. McCarthy authored
Don't prompt for passphrase or getkeys, or set the ENCRYPT flag, for OPAQUE types. Don't recurse on "text" output from decrypt_mime(). There is no reason to recurse on a text type. Additionally, the mutt_read_mime_header() will return an empty text type even if the decode doesn't generate mime output. In those cases, we want to show the original attachment.
-
- 22 Jan, 2019 2 commits
-
-
Kevin J. McCarthy authored
-
Kevin J. McCarthy authored
Change the tunnel_socket_read() and tunnel_socket_write() as the raw sockets were adjusted in the previous commit. Retry on EINTR, and complete a full write so all the implementations have the same behavior.
-
- 21 Jan, 2019 7 commits
-
-
Kevin J. McCarthy authored
-
Kevin J. McCarthy authored
The mutt_sasl.c code expects conn_write() to write the entire buffer. This is inconsistent with mutt_socket.c, but since other conn_write() implementations guarantee this, change raw_socket_write() to do so too for now. Also, update reading and writing to loop on EINTR, as gnutls does. They won't return EAGAIN or EWOULDBLOCK because we don't mark sockets as non-blocking.
-
Kevin J. McCarthy authored
It is not used anywhere in the code. Additionally, it does not interact correctly with mutt_socket_readchar() and mutt_socket_readln_d(), which use an internal input buffer: conn->inbuf. If reading a specific chunksize is needed in future, the function can be easily recreated to use the inbuf.
-
Kevin J. McCarthy authored
-
Kevin J. McCarthy authored
The gitlab registry image is built using the Dockerfile in muttmua/docker-images/tree/master/ubuntu/18.04/ Turn off the scan-build-5.0. I never look at those reports and they run very slowly. Also, for now just compile for gnutls, to speed up the check further. (cherry picked from commit f34cb1fb)
-
Kevin J. McCarthy authored
-
Kevin J. McCarthy authored
Retry on GNUTLS_E_AGAIN and GNUTLS_E_INTERRUPTED. This prevents an aborted send due to a SIGWINCH, for instance. Change tls_socket_read() to follow the same flow. Don't bother checking gnutls_error_is_fatal() because return codes besides AGAIN and INTERRUPTED end up closing the connection regardless. (We don't handle handshakes and negotations during send/receive).
-
- 19 Jan, 2019 5 commits
-
-
Kevin J. McCarthy authored
GnuPG 2.1.0, released in 2014-11-06, automatically spawns an agent. After 4+ years, it has reached wide enough usage to merit changing the default.
-
Kevin J. McCarthy authored
-
Kevin J. McCarthy authored
Add the "color compose", index-format-hook, and echo commands. Add the HMS relative date units.
-
Kevin J. McCarthy authored
-
Kevin J. McCarthy authored
It looks like LibreSSL does not perform automatic initialization of the library and error strings. Since LibreSSL defines OPENSSL_VERSION_NUMBER as a "version 2", add a check if LIBRESSL_VERSION_NUMBER is defined and call the initialization functions for that case.
-
- 18 Jan, 2019 2 commits
-
-
Vincent Lefevre authored
-
Vincent Lefevre authored
-
- 17 Jan, 2019 1 commit
-
-
Muh Muhten authored
color now accepts zero or more attributes words before the foreground. Also more or less resolves the issue that setting the color of an object which defaults to underline/reverse is irreversible.
-
- 10 Jan, 2019 2 commits
-
-
Kevin J. McCarthy authored
-
Fabian Groffen authored
Starting with POSIX.1.2008 resolved_path can be NULL. Systems implementing a standard before that crash. Example of such system is Mac OS X 10.5, the last version running on PowerPC hardware. Since this is the only occurrance of the realpath(3) function in Mutt, instead of wrapping it, just adjust this invocation. Signed-off-by:
Fabian Groffen <grobian@gentoo.org>
-