1. 23 Feb, 2019 1 commit
  2. 21 Feb, 2019 1 commit
    • Andrey Skvortsov's avatar
      Fix truncation of long filenames in attachments. · f476d0ae
      Andrey Skvortsov authored
      Currently mutt truncates long filenames in attachments and doesn't
      take into account UTF-8 character size. If filename is truncated in
      the middle of multi-byte UTF-8 character (last character is bad),
      then some mail clients assume whole attachment name bad and don't
      display its name (use 'Noname' instead).
      
      Filenames can be up to 255 *characters* long depending on used
      filesystem. ReiserFS, NFTS, FAT, APFS and some other supports up to
      255 characters.
      In the worst case 255 characters in UTF-8 will take 255*4 = 1020
      bytes. Every non-ascii byte in the filename will be encoded using 3
      bytes (for example, %8D).
      So 'Content-Disposition' will take in the worst case up to: 1020*3 =
      3060 bytes. Therefore even LONG_STRING (1024) isn't enough.
      f476d0ae
  3. 13 Feb, 2019 4 commits
  4. 07 Feb, 2019 1 commit
  5. 06 Feb, 2019 3 commits
    • Kevin J. McCarthy's avatar
      Create <group-chat-reply> function. · d97bbddf
      Kevin J. McCarthy authored
      This function differs from <group-reply> only in that it preserves To
      recipients in the original email as To recipients in the reply.
      
      The merits of this function aren't without controversy; therefore it
      is left unbound by default.  Those who care about such things are free
      to bind it.
      
      Combine reply operation handlers in the pager and curs_main, since the
      code was the same with the exception of the flags used.
      d97bbddf
    • Vincent Lefevre's avatar
      Updated French translation. · d79cb6b7
      Vincent Lefevre authored
      d79cb6b7
    • Vincent Lefevre's avatar
      corrected typo from dad0eb25 · f03088ea
      Vincent Lefevre authored
      f03088ea
  6. 02 Feb, 2019 2 commits
  7. 01 Feb, 2019 4 commits
  8. 25 Jan, 2019 2 commits
    • Kevin J. McCarthy's avatar
      Merge branch 'stable' · f0be14c2
      Kevin J. McCarthy authored
      f0be14c2
    • Kevin J. McCarthy's avatar
      Show top-level decoded smime text/plain parts. · 1041fb4f
      Kevin J. McCarthy authored
      Commit 331d9d5a attempted to fix a problem with an attachment having
      extension .p7m.  The attachment menu tried to decode and failed, and
      the part ended up being replaced by a bogus text/plain part.
      
      The problem is that crypt_smime_decrypt_mime() returns a text/plain
      part if the decode fails, meaning we can't distinguish failure from
      success in this case.
      
      As a compromise, only use a text/plain resulting from a single
      top-level application_smime part.  This will allow for the case of an
      text/plain encoded email, but won't end up hiding attachments that
      were not decoded.
      1041fb4f
  9. 24 Jan, 2019 3 commits
  10. 22 Jan, 2019 2 commits
  11. 21 Jan, 2019 7 commits
    • Kevin J. McCarthy's avatar
      Merge branch 'stable' · f4f9e5bb
      Kevin J. McCarthy authored
      f4f9e5bb
    • Kevin J. McCarthy's avatar
      Fix raw socket read/write to follow expected behavior. · 688e27a9
      Kevin J. McCarthy authored
      The mutt_sasl.c code expects conn_write() to write the entire buffer.
      This is inconsistent with mutt_socket.c, but since other conn_write()
      implementations guarantee this, change raw_socket_write() to do so too
      for now.
      
      Also, update reading and writing to loop on EINTR, as gnutls does.
      They won't return EAGAIN or EWOULDBLOCK because we don't mark sockets
      as non-blocking.
      688e27a9
    • Kevin J. McCarthy's avatar
      Remove mutt_socket_read(). · 143ea851
      Kevin J. McCarthy authored
      It is not used anywhere in the code.
      
      Additionally, it does not interact correctly with
      mutt_socket_readchar() and mutt_socket_readln_d(), which use an
      internal input buffer: conn->inbuf.
      
      If reading a specific chunksize is needed in future, the function can
      be easily recreated to use the inbuf.
      143ea851
    • Kevin J. McCarthy's avatar
      Merge branch 'stable' · 44b6e55f
      Kevin J. McCarthy authored
      44b6e55f
    • Kevin J. McCarthy's avatar
      Convert to use gitlab registry image ubuntu:18.04. · ae8bb261
      Kevin J. McCarthy authored
      The gitlab registry image is built using the Dockerfile in
      muttmua/docker-images/tree/master/ubuntu/18.04/
      
      Turn off the scan-build-5.0.  I never look at those reports and they
      run very slowly.
      
      Also, for now just compile for gnutls, to speed up the check further.
      
      (cherry picked from commit f34cb1fb)
      ae8bb261
    • Kevin J. McCarthy's avatar
      Merge branch 'stable' · 2c57d68a
      Kevin J. McCarthy authored
      2c57d68a
    • Kevin J. McCarthy's avatar
      Fix gnutls tls_socket_write() to properly retry. · 73b3151e
      Kevin J. McCarthy authored
      Retry on GNUTLS_E_AGAIN and GNUTLS_E_INTERRUPTED.  This prevents an
      aborted send due to a SIGWINCH, for instance.
      
      Change tls_socket_read() to follow the same flow.  Don't bother
      checking gnutls_error_is_fatal() because return codes besides AGAIN
      and INTERRUPTED end up closing the connection regardless.  (We don't
      handle handshakes and negotations during send/receive).
      73b3151e
  12. 19 Jan, 2019 5 commits
  13. 18 Jan, 2019 2 commits
  14. 17 Jan, 2019 1 commit
    • Muh Muhten's avatar
      Add attributes support on color declarations · 8117a33e
      Muh Muhten authored
      color now accepts zero or more attributes words before the foreground.
      
      Also more or less resolves the issue that setting the color of an object
      which defaults to underline/reverse is irreversible.
      8117a33e
  15. 10 Jan, 2019 2 commits