Skip to content

Restore ability to bank noted items when bank is full.

Natalia Cichoń requested to merge vddcore/2009scape:813-noted-items-full-bank into master

What have you done in this MR?

  • Moved the unbankable item check above the bank capacity check.
  • Moved the check for noted/unnoted so that we can catch noted items and convert them to their proper representation before doing the capacity and quantity check.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:
    I don't think it's a risky change in itself, but just to be sure, our lovely testers should keep an eye out for the regular exploits:

    • Is it not possible to add items (noted or unnoted) over the maximum bank capacity?
    • Does the bank restore noted items to their original forms and vice-versa?
    • Do the above apply to banks with expanded capacity too?

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

Closes #813 (closed)

Merge request reports