Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • Server Server
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 265
    • Issues 265
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 51
    • Merge requests 51
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • 2009Scape2009Scape
  • ServerServer
  • Merge requests
  • !901

Updated SpiritShieldBless plugin to listener

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Byte requested to merge ByteEngineer/2009scape:spirit-shield-bless-listener into master Oct 19, 2022
  • Overview 15
  • Commits 4
  • Pipelines 6
  • Changes 3

What have you done in this MR?

  • Updated SpiritShieldBless plugin to listener
  • Updated ContentAPI to include a couple of new methods for handling dialogue options and actions

Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:
  • I have tested these changes thoroughly.
  • This requires extra testing due to changes to architecture or other similarly risky changes.
  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.
  • I acknowledge that this contribution will be released under the AGPL license.

Testing: Blessing spirit shield and attaching sigils should work as normal. Blessing a spirit shield requires using a spirit shield or holy elixir on a Saradomin altar with the other in inventory. Attaching sigils requires a hammer and blessed spirit shield in inventory while using the sigil on an anvil.

Related to #230

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: spirit-shield-bless-listener