Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • Server Server
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 266
    • Issues 266
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 39
    • Merge requests 39
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • 2009Scape2009Scape
  • ServerServer
  • Merge requests
  • !755

PulseManager Update + Ecto Fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ceikry requested to merge pulsemanager-update-ecto-fix into master Aug 21, 2022
  • Overview 19
  • Commits 4
  • Pipelines 8
  • Changes 45

What have you done in this MR?

  • Made the PulseManager capable of running multiple pulses simultaneously, in different slots (this makes it function a bit more like an entity queue, though not quite.)
  • Fixed the dupe in the ectofuntus by demoting the action pulses for grinding bones from world pulses to individual pulses, and correcting a bit of the logic. (closes #703 (closed))
  • Add the ability to remove multiple attributes at once to the ContentAPI

Testers:

  • Make sure you can't reproduce #703 (closed)
  • Go die in combat (strong pulse on the pulsemanager) and make sure you can't interrupt it with any other actions or do anything else silly
  • Test interacting with a bunch of random things/moving around/etc and make sure it all feels how it should.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits, I did not edit any JSON files by hand (MR will be rejected if there are manual JSON edits).

  • I acknowledge that this contribution will be released under the AGPL license.

Edited Aug 21, 2022 by Ceikry
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: pulsemanager-update-ecto-fix