Skip to content

Return a casket, and allow nextStage to determine whether reward should be given

MatthewGould123 requested to merge MatthewGould123/2009scape:fix-interactive-clue-steps into master

What have you done in this MR?

  • With interactive clue steps, don't always return false when giving a reward, and instead let the TreasureTrailManager handle it.
  • Uncomment code to allow wizards to spawn when digging for coordinate clues.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

I disabled dev mode, spawned in interactive clue steps and then proceeded to complete the clue (for med/hard). For the wizards, I didn't complete the clues, I just spawned in coordinate clues, dug, killed the wizards, dug again and got my next casket.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits, I did not edit any JSON files by hand (MR will be rejected if there are manual JSON edits).

  • I acknowledge that this contribution will be released under the AGPL license.

How to test this MR:

For the interactive steps:

Here's a few clue ids that will have to click on objects throughout the world: 2743, 2747, 2773, 2774, 2776 (mix of med/hard).

You'll probably wanna go on to complete the full clue.

For the wizard steps:

zammy: id: 3512, loc: 3139, 3803

sara: id: 3503, loc: 2853, 3689

Obviously don't just test these, but its a start.

Closes #631 (closed)

Edited by MatthewGould123

Merge request reports