Fletching refactor
What has been done in this MR?
- I've refactored fletching
- I've removed all files that are unused
- I've converted any java I see into Kotlin
- Generally, I have tried to put emphasis on readability
- Convert skill pulses to queueScripts
- Migrate any available function calls to content API
Please be gentle, this is my first OSS PR ヾ(゚д゚)ノ゛
Having said that, if this requires a retest of fletching anyway, may as well get it as good as we can.
Apologies for the hefty PR, I got a bit excited when I started, I can try break into smaller chunks if required
What should testers check?
- Basically all fletching crafts
- Carving logs with knives
- Crafting a mithril grapple
- Attaching feathers to shafts
- Limbing crossbows
- Attaching heads to flighted arrows
- Attaching feathers to darts
- Attaching feathers to bolts
- Attaching limbs to crossbow stocks
- Chiselling gems to tips
- Attaching gem tips to bolts
- Stringing bows
- Stringing crossbows
-
I have tested these changes thoroughly. -
I used the relevant Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.
Edited by sirdabalot