Skip to content

Fixed multi threading and ring of forging charge counting

Player Name requested to merge PlayerName/2009scape:thread into master

What has been done in this MR?

  • Moved thread and ring-of-forging charge counts to a global player attribute
    • Source for thread: not necessary, the previous approach of attempting to store the charges in the charge slot could never possibly have worked correctly for stackable items. Fixes #1020 and #1052 (closed)
    • Source for ring of forging: in principle we could have fixed the current charge-slot-based system, but I found https://runescape.wiki/w/Ring_of_forging?oldid=2016274 which explicitly states that it's a player attribute and not an item charge so I went with that approach. Fixes #1977
  • Ffs, gitlab, closes #1020 closes #1977 is that the magic spell that makes you "close" rather than "mention" now?

What should testers check?

  • Thread correctly disappears every 5 items you craft with it, and the mentioned bugs can no longer be reproduced
  • Ring of forging correctly disappears every 140 iron ores you smelt wearing it, and also continues to work correctly otherwise
  • Once a previous ring of forging has been used up, the next one once again has 140 charges before crumbling

Useful item IDs:

  • Forging ring: 2568
    • Needle: 1733
    • Thread: 1734
    • Black d-leather, the one thing I used for testing: 2509 (2510 if noted)
  • I have tested these changes thoroughly.
  • I used the relevant Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.
Edited by Player Name

Merge request reports

Loading