Skip to content

Made King Bolren give back lost gnome amulets

Player Name requested to merge PlayerName/2009scape:bolren into master

What has been done in this MR?

  • Made King Bolren able to give back lost gnome amulets. Source: https://runescape.wiki/w/Gnome_amulet?oldid=810541 that he authentically gives it back, https://runescape.wiki/w/Transcript:King_Bolren for the tiny bit of relevant dialogue
  • Removed the vararg arguments from contentapi hasAnItem and instead overloaded the function to have three signatures: one that checks a single item ID, one that checks a single item ID and takes an optional boolean checkSecondBank, and one that takes multiple item IDs and takes the same optional boolean. The default behavior is not to check second bank, so as to not nerf second bank's perk of allowing players to obtain placeholder items. In the specific case of obtaining replacement family crest gauntlets, the optional argument is used to deliberately maintain the current live behavior and hence prevent the player from being able to obtain all 3 gauntlets.
  • (Fuck java for not understanding default arguments, if we hadn't needed the java interop the above bullet point could just have been a single kotlin function)

What should testers check?

  • Talk to Bolren with Tree Gnome Village completed and having an amulet, you get the normal dialogue.
  • Talk to Bolren with Tree Gnome Village completed and not having an amulet, you get a new amulet. Second bank counts as not having an amulet.
  • Confirm that, inconsistent with everything else in the game but consistent with how things are on current live, second bank continues NOT to be able to be used to obtain multiple family crest gauntlets.
  • Confirm that Thormac continues to give out scorpion cages if you lost them or secondbanked them during the Scorpion Catcher quest. (This, together with the family crest thing above, were the two only places where the varargs argument was actually utilized, so which needed to be ported.)
  • Other things that use hasAnItem() also work as you'd expect. For example, you can now use second bank to obtain placeholder camo gear pieces from Damien.

IDs useful for testing:

  • Bolren = 469
  • Quest = 125
  • Amulet = 589
  • Dimintheis for family crest gloves = 8171 (also this guy's dialogue needs a punctuation audit lmao)
  • Thormac = 389. Scorp catcher quest = 108. Set quest to stage 50 or whatever and talk to Thormac to trigger his "I've lost my cages" branch.
  • I have tested these changes thoroughly.
  • I used the relevant Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.
Edited by Player Name

Merge request reports