Skip to content

Crafting Guild Sink Fix (fix #1937)

Roderik requested to merge roderik_7/test-rs-server:CraftingGuildSinkFix into master

What has been done in this MR?

  • Made it so the crafting guild sink can be used by player (fixes #1937 (closed))

NOTE: technically the player is interacting with the noticeboard here (because of the way the core is currently implemented) so this MR adds the noticeboard to the list of watersource ids and then checks to ensure that it can only be used as a watersource in the crafting guild region on the map.

What should testers check?

  • The sink in the crafting guild can be used to fill containers like jugs and buckets.
  • No noticeboards in other locations act like watersources... (Yeah I know, that's why this is not a great way to fix it)

  • I have tested these changes thoroughly.

  • I used the relevant Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Merge request reports