Skip to content

Fix drop award if you relog mid-kill

Player Name requested to merge PlayerName/2009scape:impact into master

What has been done in this MR?

Chlex reported the following issue in chat: kill Kree'arra more than half of the way, relog, kill him the rest of the way, you don't get any drops. The reason is that the drop is awarded to the Entity that did the most damage, which is you before you logged, not you now. This MR fixes this issue.

  • Split out impact logging for NPCs and for players
  • For players, log impact by their uid, which persists across relogs
  • Fix an authenticity issue with LootShare, so that you can now authentically get drops just by standing around without actually doing any damage. Source thanks to St Danewolf: https://youtu.be/sBMeExc_eeI?t=513 plus sources in #1482. Closes #1482. Supersedes !1864 (closed).

What should testers check?

  • Relogging after killing a monster should cause the drop not to be lost
  • Otherwise, drops continue to be awarded as expected
  • Lootshare continues to work as expected
  • Ironmen continue to not receive drops if they received so much as 1hp of help from another player
  • I have tested these changes thoroughly.

  • I used the relevant Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Edited by Player Name

Merge request reports