Skip to content

Port ::ge commands to book interface

Player Name requested to merge PlayerName/2009scape:ge into master

What has been done in this MR?

  • Made ::ge buying, ::ge selling, ::ge search, ::ge botsearch, ::ge bots present their output in a book interface, removing the 300-line limit. Fixes #1826 (closed)
  • Fixes #1879 (closed)
  • Made ::ge search, ::ge botsearch take an optional extra argument(s) that gives the search string directly. If absent gives the normal input dialog.
  • Modularized the code a bit.

What should testers check?

  • The mentioned commands work as they should.
  • Test that they can list more than 300 items. One way to do this would be to edit the code locally to duplicate lines added to the interface many times.
  • Please specifically test the cases of ::ge search where it should return only one hit, as well as where they should return multiple hits. Test buying and selling separately. For example, offer a nature rune on the GE and test searching for "nature", and then also offer a nature tiara on the GE (so that there are now two items being sold) and test searching for "nature".
  • I have tested these changes thoroughly.

  • I used the relevant Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Edited by Ryan

Merge request reports