Skip to content

Rewrite POH placeDoors

Player Name requested to merge PlayerName/2009scape:placeDoors into master

What has been done in this MR?

  • Implement doors for your POH and place them where needed, i.e. where transitioning between indoors and outdoors.
  • Properly place walls where needed. No more weird alcoves if an open-ended room runs into a blind wall.
  • This also fixes the bug where you can fly out of your house. Now you can finally invite your kids to come over!
  • Thanks to the slightly different approach to removing hotspots that becomes possible with this MR, this MR also fixes the bug where some hotspots were still visible even in non-building mode (e.g.: various hotspots in the Garden, a single floating tile in Quest and Skill halls, the last few tiles of Chapel rugs, etc.)

Sources for where POHs should and should not have doors:

Note: the doors are currently always closed every time you enter your POH. This is not authentic, they're supposed to stay open for a while after you open them (see https://www.youtube.com/watch?v=nRGux739h8s). TODO as future work: change the house manager to keep the house around for ~20 minutes after you've left so that the doors will stay open for that long.

What should testers check?

  • Your POH now has: open passage if both sides of the door spot are both indoors or both outdoors, a door if they transition between indoors and outdoors and we're on the ground floor, a wall if they transition between indoors and outdoors and we're in the dungeon or on the upper floor.
  • No more lingering build hotspots in non-building mode.

Known issues that are not in scope of this MR - I will fix these in a followup MR at some point:

  • While doors open in pairs as they should, they currently do not close in pairs.
  • As mentioned above: rather than tear it down immediately, we should keep the POH instance alive for however long doors customarily stay open when the player leaves.
  • I have tested these changes thoroughly.

  • I used the relevant Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Edited by Player Name

Merge request reports