Skip to content

Convert Tanners to Kotlin; Fix Snake hide tanning

thelemir requested to merge thelemir/2009scape:TannerNPC-Fixes into master

What has been done in this MR?

  • Finished implementation of !1641 (closed)
  • Fixed #1616 (closed) - Canifis Tanner
  • Converted the following NPC dialogue to Kotlin:
    • Ellis (2824) - Al-Kharid Tanner
    • Sbott (1041) - Canifis Tanner
    • Tanner (804) - Crafting Guild Tanner
    • Ranging Guild tanner and Neitiznot tanner not updated for this MR
  • Moved tanning listener to Shops.kt - Ellis was already in here so I added Sbott and Tanner as well
  • Fixed issue where one version of snake hide (7801) wasn't craftable

Out of Scope: Canifis pricing difference - this requires changes to core functionality of tanner interface. I kept the commented-out dialogue line with the correct pricing for when this gets fixed.
Source for price difference: https://runescape.wiki/w/Tanner?oldid=486680

I kept the dialogue mostly how it was, mainly fixing the gender in the goodbye from being hardcoded to "sir". I wasn't able to find solid sources of the dialogue. The Runescape wiki doesn't have anything more recent than 2019 for dialogue transcripts, and most video sources skip the dialogue completely.

What should testers check?

  • Talk to each tanner with no hides in inventory
    • Will not be asked whether you want to tan hide(s)
    • Able to complete dialogue without issue
  • Talk to each tanner with one or more of each hide type in inventory
    • Tanner asks if you want to tan hides, even if you don't have the gold.
    • If player selects yes, tanning interface is displayed.
    • If player selects no, tanner closes dialogue with gender-specific goodbye (sir/madam)
      • Run command ::makeover to change gender and test the dialogue

Hides:

  • Cowhide (1739)
  • Snake hide (6287)
  • Snake hide (7801)
  • Green dragonhide (1753)
  • Blue dragonhide (1751)
  • Red dragonhide (1749)
  • Black dragonhide (1747)
  • I have tested these changes thoroughly.

  • I used the relevant Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Edited by thelemir

Merge request reports