Plague City refactor
What has been done in this MR?
- Refactor Plague City (Take some of !1361 (closed))
- Allow dialogues to not have the continue button for NPCs.
- Fix #1743
- Fix #1990
- The very long (5-10 sec) darkness after the cutscene existed before this MR and happens to all cutscenes that fade to black at the end. Further research needs to be done to see if this is an issue.
- Add gown from !1803 (closed)
- Fix spawns in W Ardougne, the city feels busier now
- Fix dialogues in W Ardougne
- Implement cat for death rune trading
- Lock trapdoor in Mourner HQ
- Fix drops for Mourners
- Block Elves Slayer assignment behind Regicide (despite the quest not being implemented yet)
- Add lvl 108 mourner to Elf assignment
- Implement hangover recipe fix #1908 (closed)
- Update descriptions of damage mourner equipment
- Check all children in W Ardougne have normal sized heads in chat dialogues
What should testers check?
Plague City
- Go through the quest like normal, check you can complete it
- Talk to random NPCs during the quest at random times, in particular:
- Alrena 710
- Bravek 711
- Clerk 713
- Edmond 714
- Jethick 725
- Martha 722
- Milli 724
- Ted 721
- Talk to 'special forces' Mourners (the ones in black)
- The one outside Edmond's house 718
- The one patrolling the wall on the outside 719
- The two guarding the kidnap house 3216. Actually talk to this one rather than spawn it in since it needs to be close by to another and the main door
- The couple patrolling inside the city 717
- Talk to the other mourners (348 347 371 369) while wearing just a mask (or no gear by admin-tele in) while looking for Elena
- Talk to the same mourners after you have released her
- Talk to them while wearing correct mourner gear
- Talk to them wearing extra gear
- Try and pour extra water on the mud after you have use 4 buckets.
- Keep going in and out of W Ardougne throughout the quest talking to everyone and checking the tunnels
- Try to tele to Ardougne before reading the scroll but after completing the quest. You should be blocked.
- Lose the scroll and reclaim another from Edmond
- Read the scroll and try to reclaim another from Edmond (should be blocked)
- Try to tele to Ardougne with the wrong runes/level
Other NPCs in W Ardougne to talk with
- Carla 712
- Child 355 356 (check head is right size). Try talking while wearing full mourner gear to see it toggles between Mourners and Strangers
- Civilians 785 786 787. Try talking dressed as a full mourner to get blocked immediately. Each civilian has a slightly different start/middle dialogue but they all end the same.
- Try using a cat on them to sell it for 100 death runes. Valid cats at the bottom
- Talk to the civilians without a cat
- Talk to the civilians with a cat and say no to the trade
- Talk to the civilians with a cat and say yes
- Check that only one cat at a time gets traded
- Try trading a witches cat
1491
- Head Mourner 716 (without wearing proper mourner gear)
- Talk before interacting with the kidnap house
- Talk now that you want a warrant
- Talk while wearing just mourner gear
- Talk while wearing some extra gear
- Man/Woman 728 729 351 352 353 354 360 361 362 363
- Talk and check you get 5 random dialogues
- Talk to nurse Sarah 373 check that it's her face when she is talking
- Talk to the priest 358
- Talk to the recruiter 720
- Shop with Chadwell 971 in his unmarked general store
Location.create(2466, 3285, 0)
Interactions in W Ardougne
- Check you cannot open the front door on W. Ardougne
- Trying to enter gets you shouted at
- Trying to leave tells you it's locked
- Try to enter the Mourner HQ (2036 both front and back door)
- Before Plague City is completed you get shouted at
- After Plague City you can enter. This will change as Biohazard is implemented
- Use the trapdoor in the HQ to enter the basement
-
The level 108s should attack you if you are not wearing full mourner gear. Extra gear is OK.This will have to be implemented after Mourning's End Part 1 when players can get Mourners gear
-
- Go into the tunnels. There should be a few more Dark Beasts here spread around
- Check the slavers are working in the Southern tunnels
- Confused wandering at
Location.create(2024, 4616, 0)
- 3 working hard at
Location.create(2003, 4616, 0)
- The mourners are not shouting at them yet, that can be implemented closer to Mourning's End Part 1
- Eventually these tunnels will be locked behind Mourning's End Part 1
- Confused wandering at
- You can get a doctors gown from Sarah's box after completing plague city
- When you open the sewer pipe the lid goes next to the pipe
- Both
Location.create(2516, 3320, 0)
andLocation.create(2529, 3304, 0)
let you teleport out of W Ardougne
- Both
- Check when you kill all the Mourners (besides level 108 and the level 13 boss on the roof of the Mourner's HQ) that you only get bones
- Check that you only get bones from the mourner on the roof of the HQ. This will be used more in biohazard
Other fixes
- Apparently there's a chest
Location.create(2468, 3315, 0)
in W Ardougne that is a shortcut for Tree Gnome Village- Check that when you search it you find nothing unless Tree Gnome Village is >=31.
- Make sure you can only get one Orb Of Protection
- There is an option to send dialogues where the continue button is hidden. Check another cutscene still works
anmacs
- Make a hangover cure
- Milk 1927 + Chocolate Dust 1975 -> Chocolate milk (if you're at least cooking level 4. No XP given)
- Chocolate milk 1977 + Snape Grass 231 -> Hangover cure (no cooking level required)
- Check that if you try and enter the Shanty Pass without a shanty pass the dialogue still works (this is due to it being java rather than kotlin)
Issues outside the scope of this MR
- Interface 120 and 170 are not defined in interface_config.json. Trying to define them resulted in HD showing incorrect black box sizes.
Important values:
val cats = intArrayOf(
Items.PET_CAT_1561,
Items.PET_CAT_1562,
Items.PET_CAT_1563,
Items.PET_CAT_1564,
Items.PET_CAT_1565,
Items.PET_CAT_1566,
Items.OVERGROWN_CAT_1567,
Items.OVERGROWN_CAT_1568,
Items.OVERGROWN_CAT_1569,
Items.OVERGROWN_CAT_1570,
Items.OVERGROWN_CAT_1571,
Items.OVERGROWN_CAT_1572,
Items.LAZY_CAT_6549,
Items.LAZY_CAT_6550,
Items.LAZY_CAT_6551,
Items.LAZY_CAT_6552,
Items.LAZY_CAT_6553,
Items.LAZY_CAT_6554,
Items.WILY_CAT_6555,
Items.WILY_CAT_6556,
Items.WILY_CAT_6557,
Items.WILY_CAT_6558,
Items.WILY_CAT_6559,
Items.WILY_CAT_6560,
)
val mournerGear = (
Items.MOURNER_TOP_6065, Items.MOURNER_TROUSERS_6067,
Items.GAS_MASK_1506, Items.MOURNER_BOOTS_6069,
Items.MOURNER_GLOVES_6068, Items.MOURNER_CLOAK_6070
) // Add anything else to any other slot to have 'extra gear'
Remaining items outside of this MR
- The quest log doesn't look too clean so needs to be updated
- Currently you can walk into the Mourner's Tunnels and all the way to the roof of the HQ as soon as Plague City is done. This is incorrect but other quests need to be implemented to block these fairly.
-
I have tested these changes thoroughly. -
I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.
Edited by GregF