Skip to content

Fix ironman mode being stuck after permadeath, plus some miscellaneous janitorial work

Player Name requested to merge PlayerName/2009scape:pdfixes into master

What has been done in this MR?

  • Permadeath (including HCIM death) now also resets the ironman status with the ironman manager. Fixes not being able to trade after permadeath even when you chose not to be one on tutorial island, after having permadied as one. (Issue reported by TheChimken.)
  • Removed some dead code that apparently was supposed to change HCIMs into normal IMs when they died if they were not marked as permadeath. But HCIMs are always marked as permadeath, and this is non-configurable, so this is 100% dead code.
  • Fixed a codebase-wide typo: experienceMutiplier -> experienceMultiplier. (Fortunately, the key in the player save files does not have this typo, so this is a safe change!)

What should testers check?

  • Permadie while being an ironman, then complete tutorial island (or use teleportation cheats) without becoming an ironman again. Observe that you are not subject to ironman restrictions. (Do this on a dedicated non-admin account, since admin accounts are exempt from those restrictions anyway.)
  • Confirm that your experience multiplier works as normal, even after relogging.
  • I have tested these changes thoroughly.

  • I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Merge request reports