Skip to content

Fix Construction hotspots for south-facing rooms

Player Name requested to merge PlayerName/2009scape:rotation3 into master

What has been done in this MR?

  • When a room is rotated 180 degrees (i.e. the SOUTH orientation), both the x and y coordinates of its hotspots need to be flipped. This MR adds the missing x-flipping in getHotspot. With this MR, getHotspot no longer incorrectly vertically flips its internal representation of the room, but rather rotates it 180 degrees. With this corrected rotation logic, getHotspot is now able to successfully able to locate certain hotspots in south-facing rooms when the player interacts with them for purposes of constructing stuff.

What should testers check?

  • This MR only applies to rooms that are south-facing, and only to rooms that have hotspots that are small enough that their correctly-rotated coordinates do not happen to overlap with their incorrectly-flipped coordinates. The chair hotspots in parlors are a good case. Testers should verify that, with this MR applied, parlors that have the fireplace hotspots on the southern wall now have their chair hotspots working.
  • The key behavior to watch out for is the hotspot simply not working, not even 'nothing interesting happens'. This MR intends to fix this behavior. Keep in mind that this MR only addresses south-facing rooms.
  • I have tested these changes thoroughly.

  • I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Merge request reports