Skip to content

Crafting Guild Bug Fix & Dialogues Added

Bonesy requested to merge joshking071/2009scape:crafting-cape into master

What has been done in this MR?

  • Fixed #1213 (closed), the tanning interface will now open through dialogue and "trade" option.
    • I did not change any of the dialogue or interface mechanics. If there is additional changes that need to be made or issues, please create a separate issue.
  • Rewrote the dialogue for the Master Crafter who sells the cape based on the below sources. The Master Crafter will also now provide a hood and the trimmed cape when applicable.
  • Added dialogue for the other 2 Master Crafters using the source above.
  • The trimmed crafting cape can now be used to enter the crafting guild rather than just the untrimmed cape and apron.
    • I'm not sure if it is accurate in 2009 for the Crafting cape to grant access, but the untrimmed version already did so I just added the trimmed as well.

What should testers check?

  • Buying a Crafting cape works, none of the Master Crafters have hanging dialogues, and the Tanner upstairs has a shop that opens.
  • I have tested these changes thoroughly.
  • I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Merge request reports

Loading