Skip to content

Achievement Diary check if the level above has actually been claimed

GregF requested to merge Gregf36665/2009scape:issue1485 into master

What has been done in this MR?

What should testers check?

Complete diaries appears to sometimes break on "Cook a karambwan thoroughly". If this happens during testing re-logging fixes it. This was broken before this modification

Check the following things

For all claims

  • If the player has the item (inventory, bank or equipped) then it should not be re-acquirable
  • If the player destroys the item should be re-acquirable (unless a known issue is reported)
  • If there are a sequence (eg level 1 ring, level 2 ring) make sure the first gets replaced by the second
  • Also with a sequence make sure you can't go back and get the level 1.
  • Try to destroy T2/3 and then reclaim T1/2.
  • Try to destroy T1/2 then reclaim T2/3.

Lumbridge

  • Known issue: Talking to Ned (743) about the Achievement Diary hangs no matter what state the diary is in.
  • Talk to Jack (7969) to get the level 1 ring.
  • Talk to Bob (519) to get the level 2 ring.

Falador

  • Talk to the squire (606) to claim the reward.
  • Know issue, if the shield is destroyed you cannot reclaim another one. This issue existed before this PR.

Fremennik

  • Council workman (1287) should give you sea boots 1. If you ask for more boots the dialogue hangs.
  • At the green star Yrsa (1301) will refused to talk unless you complete Fremennik Trials (64). Even still it does not work. Her dialogue file does not reference anything about the Achievement Diary.
  • Advisor Ghrim (1375) has no dialogue so the highest you can claim is sea boots 1.

Karamja

  • Talk to Pirate Jackie the Fruit (1055) to get Karamja gloves 1
  • Talk to Kaleb Paramaya (512) to get Karamaja gloves 2
  • Talk to the Jungle forester (401) to get Karamaja gloves 3. The dialogue hangs at the end.

Seer's village

  • If medium or hard is completed as well as easy the head band should still be claimable from any Seer (388).

Varrock

  • Talk to Rat Burgiss (5833) to get Varrock armour 1
  • Talk to Reldo (2660) to get Varrock armour 2. Some of his dialogue clips.
  • Talk to Vannaka (1597) but it hangs before issuing Varrock armour 3. This is an issue with the SlayerMasterDialogue.java file.

If someone wants to fix the identified issues feel free but I just wanted to get the Seer's dialogue ported to Kotlin where I discovered this issue.

  • I have tested these changes thoroughly.

  • I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Edited by GregF

Merge request reports