Convert bone burying to Kotlin
What has been done in this MR?
- Converted the bone burying plugin to listener
- Fixes #542 (closed) by stop the player when they bury bones
- Added additional bones to Bones.kt and changed the values to constants
- Removed lava dragon bones as they are not in this game
- Added burnt jogre bones which required changing the monkey bones (id 3183) bonemeal id to 4260 as it was using the second burnt bonemeal item id (4259)
- This does change the prayer xp for people who have bonemeal of that item id, but it's not a large difference and not a common bone
- Added and changed some item definitions for the jogre bones
- Removed unused bone grinding code from PhasmatysZone.java as it's handled by the bone grinder listener
Sources:
- BURNT_JOGRE_BONES_3127 - https://runescape.wiki/w/Burnt_jogre_bones?oldid=4868258
- PASTY_JOGRE_BONES_3128 - https://runescape.wiki/w/Pasty_jogre_bones_(burnt,raw)?oldid=1950076
- PASTY_JOGRE_BONES_3129 - https://runescape.wiki/w/Pasty_jogre_bones(burnt,cooked)?oldid=14743573
- MARINATED_J_BONES_3130 - https://runescape.wiki/w/Marinated_jogre_bones?oldid=1950121
- PASTY_JOGRE_BONES_3131 - https://runescape.wiki/w/Pasty_jogre_bones(raw)?oldid=14743649
- PASTY_JOGRE_BONES_3132 - https://runescape.wiki/w/Pasty_jogre_bones_(cooked)?oldid=14743624
- MARINATED_J_BONES_3133 - https://runescape.wiki/w/Marinated_jogre_bones_(bad)?oldid=14743931
What should testers check?
- Burying bones works
- Should not be able to bury any faster than before by spamming
- Bone grinding and ecto should function just as before.
- Please test different bones in Bones.kt and verify xp rates and that everything functions the same
If I did anything dumb, let me know :)
-
I have tested these changes thoroughly. -
I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.