Skip to content

Convert bone burying to Kotlin

Bonesy requested to merge joshking071/2009scape:bone-bury into master

What has been done in this MR?

  • Converted the bone burying plugin to listener
  • Added additional bones to Bones.kt and changed the values to constants
    • Removed lava dragon bones as they are not in this game
    • Added burnt jogre bones which required changing the monkey bones (id 3183) bonemeal id to 4260 as it was using the second burnt bonemeal item id (4259)
      • This does change the prayer xp for people who have bonemeal of that item id, but it's not a large difference and not a common bone
  • Added and changed some item definitions for the jogre bones
  • Removed unused bone grinding code from PhasmatysZone.java as it's handled by the bone grinder listener

Sources:

What should testers check?

  • Burying bones works
    • Should not be able to bury any faster than before by spamming
  • Bone grinding and ecto should function just as before.
    • Please test different bones in Bones.kt and verify xp rates and that everything functions the same

If I did anything dumb, let me know :)

  • I have tested these changes thoroughly.
  • I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Merge request reports

Loading