Skip to content

Make player name writing consistent

Player Name requested to merge PlayerName/2009scape:irony into master

What have you done in this MR?

  • Ensure that player names are always written as Player Name, rather than sometimes as Player_name (e.g. Genie random event) or player_name (e.g. deep wildy murder message). Also some grammar (comma) fixes in the same places while I was at it, and removed a stray println.

I did this by manually searching for and replacing instances of getName() and player.name; if I missed any, let me know!

Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:
  • I have tested these changes thoroughly.
  • This requires extra testing due to changes to architecture or other similarly risky changes.
  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.
  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports