Skip to content

Fix for issue #862 & generic changes

Trident101 requested to merge Trident101/09-scape-dev:more-misc-changes into master

What have you done in this MR?

  • Added npc ID's to make allow pickpocketing - fix for issue #862;
  • Added dialogue for shopkeeper Kofi and shop assistant, changed examine text of Kofi and added shop assistant with ID 533;
  • Rewrote Karamja man dialogue to Kotlin;
  • Rewrote Monkey dialogue to Kotlin;
  • Rewrote Zambo dialogue to Kotlin.

Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:
  • I have tested these changes thoroughly.
  • This requires extra testing due to changes to architecture or other similarly risky changes.
  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.
  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports