Skip to content

Fixed Many Issues 1

Zerken requested to merge Zerken/2009-scape-zerken:fix-many-issues-1 into master

What have you done in this MR?

  • Implemented a new Teleport zone restriction and added a check to the teleport manager to see if the player is teleport zone restricted

Resolved #1483 (closed) :

  • The firemaking cape will no longer be deleted when logging out in a darkzone

Resolved #520 (closed) :

  • The Stronghold of Security Gift of Peace, Grain of Plenty, and Box of Health will now add coins to already existing stack of coins if your inventory is full
  • The Cradle of Life will now unlock emotes from all previous Stronghold of Security levels if they have completed the other levels(This was added for older accounts which have completed the stronghold of security but are missing the emotes)

Resolved #1158 :

  • Implemented a entrana allowed item check
  • If skillcape perks are active then the player is allowed to bring the runecrafting cape(s) to entrana

Resolved #735 (closed) :

  • The teleport block in fishing trawler now only applies while on the boat and is cleared if you leave / logout
  • Fixed a issue where you could teleport out of the sunk fishing trawler
  • Fixed a issue where a logout listener was not being removed after failing the fishing trawler causing the player to be teleported to port khazard after their next login

Resolved #1158 :

  • Added a check to to see if the player has items banned on entrana
  • Added the cape to the allowed entrana items if skillcape perks are enabled

Resolved #704 : See confidential issue

  • Scales now authentically respawn in 18 seconds

Resolved #1488 (closed) :

  • Fixed the warriors guild cyclops room logout listener to properly be removed when leaving

Resolved #1475 (closed) :

  • You will no longer get stuck and will appear back at the start of the obstacle if you logout

Resolved #1100 :

  • Enchanted jewellery teleports now close any open interface

Resolved #1440 (closed) :

  • You can no longer complete the Falador medium diary goal of pickpocketing a guard unless you have 40 thieving

Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:
  • I have tested these changes thoroughly.
  • This requires extra testing due to changes to architecture or other similarly risky changes.
  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.
  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Zerken

Merge request reports

Loading